Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/nimble: fix include guards in nimble_riot.c #11232

Merged
merged 1 commit into from
Mar 26, 2019
Merged

pkg/nimble: fix include guards in nimble_riot.c #11232

merged 1 commit into from
Mar 26, 2019
+4 −0

Conversation

haukepetersen
Copy link
Contributor

Contribution description

When building NimBLE without GAT and/or GAPP GATT services, the current master will complain about missing headers in pkg/nimble/contrib/nimble_riot.c. This is due to missing include guards -> this PR fixes this.

I have some test applications in the pipeline that will trigger the faulty behavior once merged, but for streamlining the process this simple fix should be merged first.

Testing procedure

Build test should do.

Issues/PRs references

none

@haukepetersen haukepetersen added Area: pkg Area: External package ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: BLE Area: Bluetooth Low Energy support labels Mar 21, 2019
@haukepetersen haukepetersen mentioned this pull request Mar 21, 2019
Merged
miri64
miri64 approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, straight forward change and Murdock still is okay with it.

@miri64 miri64 merged commit 97c4fef into RIOT-OS:master Mar 26, 2019
@haukepetersen haukepetersen deleted the fix_nimble_includeguardsriotinit branch March 26, 2019 13:18
@danpetry danpetry added this to the Release 2019.04 milestone Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miri64 miri64 miri64 approved these changes

Assignees
No one assigned
Labels
Area: BLE Area: Bluetooth Low Energy support Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.04
Development

Successfully merging this pull request may close these issues.
3 participants
@haukepetersen @miri64 @danpetry